Fix merged reports sorting - #1003
Open
taobojlen wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
from
August 12, 2026 03:05
d4673b4 to
7388923
Compare
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
2 times, most recently
from
August 17, 2026 10:22
bbf8dcf to
9e389b0
Compare
taobojlen
changed the base branch from
fix/recent-decision-summary-keys
to
fix/user-approval-status-sorting
August 17, 2026 10:23
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
from
August 17, 2026 15:43
9e389b0 to
ec7c8be
Compare
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
2 times, most recently
from
August 18, 2026 09:25
5f710f7 to
5427a1c
Compare
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
2 times, most recently
from
August 18, 2026 10:13
a28e70b to
c815ac6
Compare
taobojlen
force-pushed
the
fix/merged-reports-sorting
branch
from
August 18, 2026 10:19
c815ac6 to
6ebae29
Compare
taobojlen
marked this pull request as ready for review
August 18, 2026 11:21
taobojlen
requested review from
cassidyjames,
dom-notion,
juanmrad,
julietshen and
vinaysrao1
as code owners
August 18, 2026 11:21
cassidyjames
force-pushed
the
fix/merged-reports-sorting
branch
from
August 21, 2026 15:26
6ebae29 to
8b87c68
Compare
cassidyjames
force-pushed
the
fix/merged-reports-sorting
branch
from
August 21, 2026 15:33
8b87c68 to
a99177b
Compare
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
cassidyjames
force-pushed
the
fix/merged-reports-sorting
branch
from
August 21, 2026 17:04
a99177b to
7ad6131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
The merged reports table was using the wrong sort functions, so sorting the table was broken. Now fixed.
Tests
See regression test.
Also tested manually.
(Optional) Rollout Plan
N/A
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):Did you update the CHANGELOG.md and related docs?
If you changedserver/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:Did you update the corresponding history tables and their triggers?
If you changeddb/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal inserver/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.